Wireshark-commits: [Wireshark-commits] master-1.12 f0e8636: If we don't find a NetScaler signature,
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 18 Aug 2014 00:34:17 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f0e86360b3b8b17ab6820776172f06ba431b9154
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

f0e8636 by Guy Harris (guy@xxxxxxxxxxxx):

    If we don't find a NetScaler signature, don't report an error.
    
    It's *NOT* an error; it's just a file that isn't a NetScaler file.
    Otherwise, we report errors on files that should just be passed on to
    other open routines.
    
    Also, NetScaler files are *NOT* text files, and we should *NOT* use
    ".txt" as the suffix.
    
    Change-Id: If001abbbbc3de3ea27439a44a47ce1d6071d38ae
    Reviewed-on: https://code.wireshark.org/review/3678
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit b8293f95ad18bc1cc00363627471c880d0f4e5a2)
    Reviewed-on: https://code.wireshark.org/review/3679
    

Actions performed:

    from  968858c   [Automatic manuf, services and enterprise-numbers update for 2014-08-17]
    adds  f0e8636   If we don't find a NetScaler signature, don't report an error.


Summary of changes:
 wiretap/file_access.c |    2 +-
 wiretap/netscaler.c   |   15 ++++++++-------
 2 files changed, 9 insertions(+), 8 deletions(-)