Wireshark-commits: [Wireshark-commits] master 433eeda: When checking if a message is Diameter also
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 12 Aug 2014 18:31:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=433eeda109bdd5e4ed3860d13ea67e357befae6b
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

433eeda by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    When checking if a message is Diameter also check for a minimum message length.
    
    This improves the detection of Diameter messages within a TCP bytestream (i.e.,
    when the Diameter PDUs don't neatly align with frames).
    
    Bug: 10362
    Change-Id: I49a6e8cf076a6ab8a14761493aab9f3b11e4756e
    Reviewed-on: https://code.wireshark.org/review/3557
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  b698426   Remove unneeded include of config.h
    adds  433eeda   When checking if a message is Diameter also check for a minimum message length.


Summary of changes:
 epan/dissectors/packet-diameter.c |   49 +++++++++++++++++++++++++------------
 1 file changed, 33 insertions(+), 16 deletions(-)