Wireshark-commits: [Wireshark-commits] master e7301a1: packet-hislip.c: Fix various bugs and defici
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 10 Aug 2014 23:01:49 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e7301a15ab814e4070f918bba8561f291623faae
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e7301a1 by Bill Meier (wmeier@xxxxxxxxxxx):

    packet-hislip.c: Fix various bugs and deficiencies
    
    - Remove an incorrect call to conversation_new()
      (which messed up TCP sequence number analysis).
    - hislip Request/Response analysis must be done during 'pass1'
      (i.e. when 'flags.visited == 0');
      Not doing so caused various problems including
       tshark '1 pass' poor dissection.
    - Remove 'if (tree)' around a call to expert_...().
    - Don't show "unknown" for Async/Sync when the value is actually known.
    - Simplify some code.
    - Mark a field as GENERATED.
    
    Change-Id: I286c12f52e5f73377bed3a2792f3ff0003e2785f
    Reviewed-on: https://code.wireshark.org/review/3541
    Petri-Dish: Bill Meier <wmeier@xxxxxxxxxxx>
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  d13b031   packet-lg8979.c: Various minor changes
    adds  e7301a1   packet-hislip.c: Fix various bugs and deficiencies


Summary of changes:
 epan/dissectors/packet-hislip.c |  130 ++++++++++++++++++---------------------
 1 file changed, 60 insertions(+), 70 deletions(-)