Wireshark-commits: [Wireshark-commits] master 79c55a3: Fix Bug #10348 Different dissection results
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 5 Aug 2014 13:36:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=79c55a34cb9869a846ed4e58a760c50e409eeeb5
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

79c55a3 by AndersBroman (anders.broman@xxxxxxxxxxxx):

    Fix Bug #10348 Different dissection results for same file.
    The fault is that reassembly_table_init() must be called when reloading
    the file - move it to an init routine and register the init routine.
    While there move the proto_register_opcua() routine to the end of the file
    to be more consistent with other dissectors.
    Change soft deprecated APIs
    
    Change-Id: I2b93692be24dbf60f4ef09aa7283e55ebf3c1874
    Reviewed-on: https://code.wireshark.org/review/3431
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8b2a8a9   Suppress 10 of the CMP0020 CMake warnings on Windows, only 8 left now.
    adds  79c55a3   Fix Bug #10348 Different dissection results for same file. The fault is that reassembly_table_init() must be called when reloading the file - move it to an init routine and register the init routine. While there move the proto_register_opcua() routine to the end of the file to be more consistent with other dissectors. Change soft deprecated APIs


Summary of changes:
 plugins/opcua/opcua.c |  189 ++++++++++++++++++++++++++-----------------------
 1 file changed, 99 insertions(+), 90 deletions(-)