Wireshark-commits: [Wireshark-commits] master 37b5b09: Rip out the filetap code
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 4 Aug 2014 14:31:39 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=37b5b095b90ea714478049408084f39707882a06
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

37b5b09 by Evan Huus (eapache@xxxxxxxxx):

    Rip out the filetap code
    
    We decided at sharkfest that this wasn't the right design for file dissection;
    we have more-or-less settled on way forward, but nobody's shown interest in
    implementing it. Whether or not that ever happens, this code is effectively
    dead and should be removed.
    
    Change-Id: I14d6086df3204fffb6485228db39d9f407661417
    Reviewed-on: https://code.wireshark.org/review/3400
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  76e4698   Always create subtree in proto_item_add_subtree().
    adds  37b5b09   Rip out the filetap code


Summary of changes:
 CMakeLists.txt             |    7 +-
 Makefile.am                |    8 -
 Makefile.nmake             |   29 +-
 config.nmake               |    5 -
 configure.ac               |    1 -
 filetap/CMakeLists.txt     |   88 ---
 filetap/Makefile.am        |   78 ---
 filetap/Makefile.common    |   38 -
 filetap/Makefile.nmake     |   57 --
 filetap/file_access.c      | 1001 ---------------------------
 filetap/ft_file_wrappers.c | 1647 --------------------------------------------
 filetap/ft_file_wrappers.h |   59 --
 filetap/ftap-int.h         |  250 -------
 filetap/ftap.c             |  478 -------------
 filetap/ftap.h             |  388 -----------
 image/Makefile.nmake       |    7 +-
 image/filetap.rc.in        |   34 -
 make-version.pl            |    6 +-
 tfshark.c                  |   56 +-
 19 files changed, 28 insertions(+), 4209 deletions(-)
 delete mode 100644 filetap/CMakeLists.txt
 delete mode 100644 filetap/Makefile.am
 delete mode 100644 filetap/Makefile.common
 delete mode 100644 filetap/Makefile.nmake
 delete mode 100644 filetap/file_access.c
 delete mode 100644 filetap/ft_file_wrappers.c
 delete mode 100644 filetap/ft_file_wrappers.h
 delete mode 100644 filetap/ftap-int.h
 delete mode 100644 filetap/ftap.c
 delete mode 100644 filetap/ftap.h
 delete mode 100644 image/filetap.rc.in