Wireshark-commits: [Wireshark-commits] master 5460d7f: Only fake an item by returning 'tree' if the
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 3 Aug 2014 17:24:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5460d7fa0cd13f84ff567c96ee89d07b37cd4b62
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5460d7f by Evan Huus (eapache@xxxxxxxxx):

    Only fake an item by returning 'tree' if they use the same TVB
    
    Otherwise the offsets will be wrong when calling, e.g. proto_item_set_end.
    
    Bug:10329
    Change-Id: I5ae0c660af90678e446817b65f83c075e7c0b84e
    Reviewed-on: https://code.wireshark.org/review/3341
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  a6fc5a3   Cast G_STRUCT_OFFSET to gint to fix mac buildbot
    adds  5460d7f   Only fake an item by returning 'tree' if they use the same TVB


Summary of changes:
 epan/proto.c |   89 +++++++++++++++++++++++++++++-----------------------------
 1 file changed, 45 insertions(+), 44 deletions(-)