Wireshark-commits: [Wireshark-commits] master a644744: Use packet_scope instead of a stack local
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 1 Aug 2014 09:32:33 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a644744fb9502971fee751b8a1e390d255b82d78
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a644744 by Evan Huus (eapache@xxxxxxxxx):

    Use packet_scope instead of a stack local
    
    As clang pointed out we end up storing a reference to it in a global and (more
    relevantly) pushing that global to a tap which would run after the current frame
    has returned.
    
    Thanks to Alexis for bringing this to my attention.
    
    Change-Id: I3aac43a806d217b0dc8a973f6bb2fa48cdd041bb
    Reviewed-on: https://code.wireshark.org/review/3289
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  dc9b44c   Ignore RPM output directories.
    adds  a644744   Use packet_scope instead of a stack local


Summary of changes:
 epan/dissectors/packet-dcerpc.c |   42 +++++++++++++++++++--------------------
 1 file changed, 21 insertions(+), 21 deletions(-)