Wireshark · Wireshark-commits: [Wireshark-commits] master 0272b9c: Fix heap-use-after-free via setlocale

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0272b9c435db6b8665504d402ce1a23325f5b409
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0272b9c by Peter Wu (peter@xxxxxxxxxxxxx):

    Fix heap-use-after-free via setlocale
    
    setlocale returns a statically-allocated memory which can be modified by
    subsequent calls of setlocale. This triggers a heap-use-after free in
    ASAN when the setlocale function is called again with the previous
    pointer.
    
    This was found when trying to use the "Show All Streams" option via
    the Telephony -> RTP menu.
    
    While at it, add some modelines
    
    Change-Id: Ide47e877ce828734fd8c5c1b064d9c505ba2b37a
    Reviewed-on: https://code.wireshark.org/review/3234
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  3db115a   Add a couple more dissector authors.
    adds  0272b9c   Fix heap-use-after-free via setlocale


Summary of changes:
 echld/dispatcher.c        |   13 ++++++++++++-
 ui/cli/tap-rtp.c          |   16 +++++++++++++++-
 ui/gtk/gui_utils.c        |    3 ++-
 ui/gtk/hostlist_table.c   |    3 ++-
 ui/gtk/iax2_analysis.c    |    3 ++-
 ui/gtk/mcast_stream_dlg.c |   15 ++++++++++++++-
 ui/gtk/rtp_stream_dlg.c   |   15 ++++++++++++++-
 7 files changed, 61 insertions(+), 7 deletions(-)