Wireshark-commits: [Wireshark-commits] master 2a1e3d1: Fix two bugs in kafka dissection
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 24 Jun 2014 21:59:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2a1e3d16aae8bf52c4d8fa9c950ae0e571f16fd2
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2a1e3d1 by Evan Huus (eapache@xxxxxxxxx):

    Fix two bugs in kafka dissection
    
     - Respect the length field when dissecting message sets
     - Don't "wrap around" in capture when doing request/response matches
    
    Also convert one instance to proto_tree_add_subtree, as an experiment.
    
    Change-Id: Id161687865afa7ca83e6943a643bc54582f65554
    Reviewed-on: https://code.wireshark.org/review/2624
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  0fb9369   Support -w even if we're not built with pcap.
    adds  2a1e3d1   Fix two bugs in kafka dissection


Summary of changes:
 epan/dissectors/packet-kafka.c |   41 +++++++++++++++++++++++-----------------
 1 file changed, 24 insertions(+), 17 deletions(-)