Wireshark-commits: [Wireshark-commits] master a45ce57: Optimize dissect_sip_route_header()
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 19 Jun 2014 22:16:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a45ce57a1a64adfe48e7c133ecd1ee50182fc9b6
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a45ce57 by Jakub Zawadzki (darkjames@xxxxxxxxxxxx):

    Optimize dissect_sip_route_header()
    
    Don't manually fetch each character to find ',' use tvb_find_guint8()
    
    Change-Id: I29711421469e868a86bf2edd7adf8dcc85ed26eb
    Reviewed-on: https://code.wireshark.org/review/2446
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8b12768   calling subdissectors shouldn't be conditional on a tree
    adds  a45ce57   Optimize dissect_sip_route_header()


Summary of changes:
 epan/dissectors/packet-sip.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)