Wireshark-commits: [Wireshark-commits] master-1.12 d2b6365: Create and register subtree identifiers
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 Jun 2014 19:38:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d2b63655fa79062edf05373580a7b6a9e12bf4ed
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

d2b6365 by Hannes Mezger (hannes.mezger@xxxxxxxxxxx):

    Create and register subtree identifiers for all opcua array types
    
    Currently for all arrays, the generic ett_opcua_array is used, instead we want to be more selective for storing the expanded state of subtrees. This commit adds subtree identifiers for all array types.
    
    Change-Id: Idcec51a200d1109cdb557d3366021d3b066b453d
    Reviewed-on: https://code.wireshark.org/review/2176
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 7067e3a34006cc15b5d050e9dd564ced0cb1bd9b)
    Reviewed-on: https://code.wireshark.org/review/2314
    

Actions performed:

    from  8e5241a   Unify how opcua arrays are displayed
    adds  d2b6365   Create and register subtree identifiers for all opcua array types


Summary of changes:
 plugins/opcua/opcua_complextypeparser.c |  733 +++++++++++++++++++++----------
 plugins/opcua/opcua_complextypeparser.h |  272 +++++++++++-
 plugins/opcua/opcua_enumparser.c        |   61 ++-
 plugins/opcua/opcua_enumparser.h        |   31 +-
 plugins/opcua/opcua_serviceparser.c     |  489 ++++++++++++++-------
 plugins/opcua/opcua_serviceparser.h     |  275 +++++++++++-
 plugins/opcua/opcua_simpletypes.c       |  116 +++--
 plugins/opcua/opcua_simpletypes.h       |   33 +-
 8 files changed, 1571 insertions(+), 439 deletions(-)