Wireshark-commits: [Wireshark-commits] master-1.12 c6736f0: isakmp: allow IKEv1 decryption with non
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 Jun 2014 17:56:33 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c6736f036e56b099005df7d2b4f5a4f0075782dc
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

c6736f0 by Alex Badea (abadea@xxxxxxxxxxx):

    isakmp: allow IKEv1 decryption with non-PSK authentication
    
    There is a check that disables decryption for non-PSK authentication. It
    has been around ever since its introduction in commit acfe071e (svn
    r17229). As suggested in bug 7951, remove this check to allow decryption
    for e.g. certificates authentication.
    
    Bug: 7951
    Change-Id: I5e98407d0f8dbabac2cdaf632cf0af403192872b
    Signed-off-by: Alex Badea <abadea@xxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/2297
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit f9b05dc13213832dba10600bd0116505ed251fec)
    Reviewed-on: https://code.wireshark.org/review/2305
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  c41b64b   Cleanup subtree types in opcua plugin
    adds  c6736f0   isakmp: allow IKEv1 decryption with non-PSK authentication


Summary of changes:
 epan/dissectors/packet-isakmp.c |    1 -
 1 file changed, 1 deletion(-)