Wireshark · Wireshark-commits: [Wireshark-commits] master 9ac8052: glusterfs: correctly decode GFIDs that are passed in a dict

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9ac8052fb10bf88f51dc35872d69d234eaa451fb
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9ac8052 by Niels de Vos (ndevos@xxxxxxxxxx):

    glusterfs: correctly decode GFIDs that are passed in a dict
    
    When a dict structure is passed by GlusterFS, the values are not encoded
    normally. We now assume that the GFID in the dict is in network-order,
    but this will be incorrect for Big Endian systems. The majority of
    Gluster deployments are on Little Endian, and the GFID is displayed
    correctly for this case. I am sorry for the few users on Big Endian
    Gluster environments, they will see some GFIDs in Wireshark that don't
    exist on the Gluster volume.
    
    With this change, it is also made possible to filter on the GFID that is
    contained inside of the dict.
    
    Change-Id: I62a265eca34df23a507403397012cf652d43ca54
    Reported-by: Vikhyat Umrao <vumrao@xxxxxxxxxx>
    Signed-off-by: Niels de Vos <ndevos@xxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/1856
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  2f369b2   Cleanup subtree types in opcua plugin
    adds  9ac8052   glusterfs: correctly decode GFIDs that are passed in a dict


Summary of changes:
 epan/dissectors/packet-glusterfs.c |   24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)