Wireshark-commits: [Wireshark-commits] master-1.12 65c6ba6: Fix switch case on ExpandedNodeId encod
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 12 Jun 2014 19:50:38 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=65c6ba690f2894910b3290a9165d1c1146345df3
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

65c6ba6 by Hannes Mezger (hannes.mezger@xxxxxxxxxxx):

    Fix switch case on ExpandedNodeId encoding mask
    
    Only the bits 0-3 are significant for the type of the NodeId contained in the ExpandedNodeId.
    The other bits are a mask telling if a NamespaceUri and/or a ServerIndex is set.
    
    Change-Id: I17948524f8a1bf6cb9dffc5f66ec5cddee580bcd
    Reviewed-on: https://code.wireshark.org/review/2120
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit 6ddf081f6448c016987330fa6ada210dbc79d0ab)
    Reviewed-on: https://code.wireshark.org/review/2167
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  e519b31   X11: Update generated dissector
    adds  65c6ba6   Fix switch case on ExpandedNodeId encoding mask


Summary of changes:
 plugins/opcua/opcua_simpletypes.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)