Wireshark-commits: [Wireshark-commits] master bd84767: Added tap queue helper function to USB disse
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 6 Jun 2014 14:14:30 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bd847676741a401ee8efc749e7dd8390606c6e07
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bd84767 by Sean O. Stalley (sean.stalley@xxxxxxxxx):

    Added tap queue helper function to USB dissector
    
    Added a helper function which handles all the USB-Specific tap data.
    
    This is part of an effort to make dissect_usb_common() more modular
    so that code can be shared between the USB & the MAUSB dissector.
    
    Change-Id: If0f0b5542203ddaed28009d8a8a1bb8660fa5d70
    Reviewed-on: https://code.wireshark.org/review/1990
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  ed2bb85   Fix Dereference of null pointer found by Clang analyzer
    adds  bd84767   Added tap queue helper function to USB dissector


Summary of changes:
 epan/dissectors/packet-usb.c |   35 +++++++++++++++++++----------------
 1 file changed, 19 insertions(+), 16 deletions(-)