Wireshark-commits: [Wireshark-commits] master c94d2e6: MAUSB dissector uses USB addresses
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 4 Jun 2014 00:56:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c94d2e684845da027e7d66a85ec4b615c83abd61
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c94d2e6 by Sean O. Stalley (sean.stalley@xxxxxxxxx):

    MAUSB dissector uses USB addresses
    
    The MAUSB dissector now prints the USB address for MAUSB data packets
    in the Source & Destination columns. Before, the IP address was
    printed.
    
    All MAUSB data packets are now part of USB Conversations. Like the
    USB dissector, all data to & from one endpoint are part of the same
    conversation.
    
    Issues that need to be resolved:
    - In the case where multiple MAUSB packets exist in one TCP packet,
      only one USB address can be printed.
    - The USB conversations do not appear in the conversations window.
      They should appear under the USB conversations tab.
    
    Change-Id: I042daf7889cf70b3bbc450f9ccd974a0f93f4798
    Reviewed-on: https://code.wireshark.org/review/1943
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  c6d175e   Guarantee that open routines are initialized
    adds  c94d2e6   MAUSB dissector uses USB addresses


Summary of changes:
 epan/dissectors/packet-mausb.c |   41 ++++++++++++++++++++++++++++++++++++++++
 epan/dissectors/packet-usb.c   |    4 ++--
 epan/dissectors/packet-usb.h   |   12 ++++++++++++
 3 files changed, 55 insertions(+), 2 deletions(-)