Wireshark · Wireshark-commits: [Wireshark-commits] master-1.12 e50fe32: LLDP : Fix bug in mdi_power_source hf. While it compiles fi

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e50fe32474ba554d440e428588dd54af089e1064
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

e50fe32 by Anish Bhatt (anish@xxxxxxxxxxx):

    LLDP : Fix bug in mdi_power_source hf.
    While it compiles fine, hits an assert in add_string :
    failed assertion "hfinfo->type == FT_STRING || hfinfo->type == FT_STRINGZ || hfinfo->type == FT_STRINGZPAD"
    
    Fix takes care of this issue, but seems like we're losing the bitmask info here, is there a better way to do this ?
    
    Change-Id: I7156d734f4b058113730d5dfbf6498e801c36770
    Signed-off-by: Anish Bhatt <anish@xxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/1915
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit de9efa1cb91afddb70d1b56a2574fb0def628bd3)
    Reviewed-on: https://code.wireshark.org/review/1930
    

Actions performed:

    from  aec0627   EIGRP Sequence TLV Dissector Patch
    adds  e50fe32   LLDP : Fix bug in mdi_power_source hf. While it compiles fine, hits an assert in add_string : failed assertion "hfinfo->type == FT_STRING || hfinfo->type == FT_STRINGZ || hfinfo->type == FT_STRINGZPAD"


Summary of changes:
 epan/dissectors/packet-lldp.c |   18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)