Wireshark-commits: [Wireshark-commits] master e3473c9: Bluetooth: AVDTP: Upgrade session logic
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 30 May 2014 11:25:36 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e3473c921fe1780b23cb0f046d0c2a7558743518
Submitter: Michal Labedzki (michal.labedzki@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e3473c9 by Michal Labedzki (michal.labedzki@xxxxxxxxx):

    Bluetooth: AVDTP: Upgrade session logic
    
    To correctly resolve connections single "ID" value
    like L2CAP PSM, is not enough, because next connection may use
    the same PSM value. Solution is save frame number of frame that
    make disconnection.
    
    Conclusion:
    Any session key values should be updated to pair:
    {ID_1, disconnect_in_frame}, {ID_2, disconnect_in_frame}...
    then we should check if  "disconnect_in_frame" is greater then
    current frame number, otherwise it is not valid session.
    
    Change-Id: I3d760112b6e53358a93c994f4aae455ac1bf5de6
    Reviewed-on: https://code.wireshark.org/review/1878
    Tested-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    Reviewed-by: Michal Labedzki <michal.labedzki@xxxxxxxxx>
    

Actions performed:

    from  2abc541   Bluetooth AVDTP/RTP: Separate the streams
    adds  e3473c9   Bluetooth: AVDTP: Upgrade session logic


Summary of changes:
 epan/dissectors/packet-btavdtp.c |    8 +++++---
 epan/dissectors/packet-btl2cap.c |    6 ++++++
 epan/dissectors/packet-btl2cap.h |    1 +
 3 files changed, 12 insertions(+), 3 deletions(-)