Wireshark · Wireshark-commits: [Wireshark-commits] master 70d67a2: Make packet-ieee80211.c a tiny bit less unreadable. <rant> This

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=70d67a21ae43957b817263d3bb5aa4c0f2608d0e
Submitter: Jörg Mayer (jmayer@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

70d67a2 by Joerg Mayer (jmayer@xxxxxxxxx):

    Make packet-ieee80211.c a tiny bit less unreadable.
    <rant>
    This file is riddled with lots of magical flags causing the code to do
    one thing or another, and then in several cases with non-telling variable
    names (e.g. is_centrino). My absolute favourite is
    
      dissect_ieee80211_common (tvb, pinfo, tree, FALSE,
                                pinfo->pseudo_header->ieee_802_11.fcs_len, FALSE, FALSE, FALSE, FALSE);
    
    Is there anyone who is able to understand what the line above does without
    looking up the function definition?
    </rant>
    
    Change-Id: Id49cc0a2992005c28f66a8558e4b2970b677a360
    Reviewed-on: https://code.wireshark.org/review/1805
    Reviewed-by: Jörg Mayer <jmayer@xxxxxxxxx>
    

Actions performed:

    from  26840fa   Replace manual string handling with strbuf
    adds  70d67a2   Make packet-ieee80211.c a tiny bit less unreadable. <rant> This file is riddled with lots of magical flags causing the code to do one thing or another, and then in several cases with non-telling variable names (e.g. is_centrino). My absolute favourite is


Summary of changes:
 epan/dissectors/packet-ieee80211.c |   20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)