Wireshark-commits: [Wireshark-commits] master 9fe221a: Fix newly optimized strdup_vprintf.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 17 May 2014 12:30:04 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9fe221a42f6085d6345a5ee6b5deb47d93b264de
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9fe221a by Evan Huus (eapache@xxxxxxxxx):

    Fix newly optimized strdup_vprintf.
    
    As Jakub pointed out, our +1/-1 logic for null terminators wasn't quite right.
    Also be sure to re-copy the va_list parameter if we need to re-use it, as
    otherwise things break oddly.
    
    Change-Id: Ibeaa95af602f565791e9378a6cfce434f13025eb
    Reviewed-on: https://code.wireshark.org/review/1670
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  72a6a8c   Fixes after wmem_strdup_vprintf() optimization
    adds  9fe221a   Fix newly optimized strdup_vprintf.


Summary of changes:
 epan/wmem/wmem_strutl.c |   13 ++++++++-----
 epan/wmem/wmem_test.c   |    3 +++
 2 files changed, 11 insertions(+), 5 deletions(-)