Wireshark-commits: [Wireshark-commits] master 33750ab: IP Protocol : Update description of IP Proto
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 16 May 2014 14:18:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=33750ab4b4df833b35a9f141a5089e22c4aa534e
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

33750ab by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    IP Protocol : Update description of IP Protocol
    
    From Boaz
    
    In IANA the two IPv4 protocols are defined:
    
    35	IDPR	Inter-Domain Policy Routing Protocol
    45	IDRP	Inter-Domain Routing Protocol
    http://www.iana.org/assignments/protocol-numbers/protocol-numbers.xhtml
    
    However, in Wireshark, they are named:
    
    { IP_PROTO_IDPR,    "Interdomain routing" },    /* 35 IDPR Inter-Domain Policy Routing Protocol [Martha_Steenstrup] */
    { IP_PROTO_IDRP,    "IDRP" },                   /* 45 IDRP Inter-Domain Routing Protocol [Sue_Hares] */
    
    Which is somewhat confusing.
    
    I think IDPR should be named "Inter-Domain Policy Routing".
    And IDRP should be named "Inter-Domain Routing Protocol".
    
    Change-Id: I69b34ea8d9b3169fd779357710edb44cfb5cb2b3
    Reviewed-on: https://code.wireshark.org/review/1664
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c3513b4   Add modelines info
    adds  33750ab   IP Protocol : Update description of IP Protocol


Summary of changes:
 epan/ipproto.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)