Wireshark-commits: [Wireshark-commits] master-1.10 5cdb0c3: Don't use -1 as length in frame dissect
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 14 May 2014 17:29:37 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5cdb0c35aa3ca7ec5a3af9c166c42c9a01f9eefc
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

5cdb0c3 by Evan Huus (eapache@xxxxxxxxx):

    Don't use -1 as length in frame dissector.
    
    Additional belated followup to gfe195c0c9 per conversation on -dev about the use
    of -1 and when we should throw exceptions. See also g867a1827e7.
    
    Should (in theory) permit reverting gfe195c0c9 (which was not in 1.10)
    
    Bug:9999
    Bug:10030
    Change-Id: I56e5f4e5dc12fe82268243d0b113cfc9ff5fdd17
    Reviewed-on: https://code.wireshark.org/review/1603
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    
    Conflicts:
    	epan/dissectors/packet-frame.c
    
    Change-Id: Ibeb119f911a698d44f4baa06d888bb1e775983bc
    Reviewed-on: https://code.wireshark.org/review/1640
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  40fe99a   Deleted one line to much in previous chgange.
    adds  5cdb0c3   Don't use -1 as length in frame dissector.


Summary of changes:
 epan/dissectors/packet-frame.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)