Wireshark · Wireshark-commits: [Wireshark-commits] master d7c4bde: tcp: display calculated checksum

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d7c4bde2799084aee717dbaa04d7fd4be06cd989
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d7c4bde by Peter Wu (peter@xxxxxxxxxxxxx):

    tcp: display calculated checksum
    
    While debugging a network issue, I found incorrect TCP checksums. These
    are shown in the packet details, but are not available as column. This
    patch adds the "tcp.checksum_calculated" field which is only available
    if a checksum can be calculated (i.e., checksumming is enabled and the
    full segment is available).
    
    The fields are added separately for each checksum case to make it appear
    before "Checksum Bad/Good" and to avoid calculating the expected field
    value for the "good" cases.
    
    Change-Id: I36af7894d526382ef636c5fa51e74871212b2909
    Reviewed-on: https://code.wireshark.org/review/1627
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  aa5d912   Add a comment indicating that 'PLATFORM' is apparently set only for X64.
    adds  d7c4bde   tcp: display calculated checksum


Summary of changes:
 epan/dissectors/packet-tcp.c |   19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)