Wireshark-commits: [Wireshark-commits] master beb119f: Don't use -1 as length in frame dissector.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 14 May 2014 15:42:29 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=beb119f911a698d44f4baa06d888bb1e775983bc
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

beb119f by Evan Huus (eapache@xxxxxxxxx):

    Don't use -1 as length in frame dissector.
    
    Additional belated followup to gfe195c0c9 per conversation on -dev about the use
    of -1 and when we should throw exceptions. See also g867a1827e7.
    
    Should (in theory) permit reverting gfe195c0c9.
    
    Bug:9999
    Bug:10030
    Change-Id: I56e5f4e5dc12fe82268243d0b113cfc9ff5fdd17
    Reviewed-on: https://code.wireshark.org/review/1603
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  b2055d7   Update enums to SISO_REF_010-00v20-0 Annex A, section A.1 and A.2
    adds  beb119f   Don't use -1 as length in frame dissector.


Summary of changes:
 epan/dissectors/packet-frame.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)