Wireshark-commits: [Wireshark-commits] master be3a153: tcp: move & optimize printing tcp flags to s
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 6 May 2014 06:41:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=be3a15370759936dcba406ab1195d939a3647f94
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

be3a153 by Jakub Zawadzki (darkjames@xxxxxxxxxxxx):

    tcp: move & optimize printing tcp flags to seperate routine.
    
    The formatting routine is quite simple so it can be replaced with
    g_stpcpy() and still keeping it clean.
    
    Change-Id: Ifbab1dc1140ee271d39bbbfb7586cfda6ded5c54
    Reviewed-on: https://code.wireshark.org/review/1517
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  f764765   Increase the work used to time wmem allocators
    adds  be3a153   tcp: move & optimize printing tcp flags to seperate routine.


Summary of changes:
 epan/dissectors/packet-tcp.c |   65 ++++++++++++++++++++++++------------------
 1 file changed, 38 insertions(+), 27 deletions(-)