Wireshark-commits: [Wireshark-commits] master 8f2f727: Not finding a non-required package is *NOT*
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 5 May 2014 03:12:15 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8f2f7275717f07da2adeee81e70ddb8757fe3af3
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8f2f727 by Guy Harris (guy@xxxxxxxxxxxx):

    Not finding a non-required package is *NOT* an error!
    
    If you think not finding a package that the user specifies should be
    used should be an error, please fix bug 10074 first - not finding a
    package that the user *didn't* specify should be used or shouldn't be
    used should not be an error.
    
    Change-Id: I62aba4309e227352e114f2d291aaa74dba78840f
    Reviewed-on: https://code.wireshark.org/review/1498
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  0b0c98a   set(<variable>) *undefines* the variable; a value must be specified.
    adds  8f2f727   Not finding a non-required package is *NOT* an error!


Summary of changes:
 CMakeLists.txt |   11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)