Wireshark-commits: [Wireshark-commits] master 6a80524: Cleanup SPDY dissector.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 1 May 2014 14:15:41 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6a8052434192b36c6d4abfb4644ec54827b3812a
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6a80524 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Cleanup SPDY dissector.
    
    Address Evan's missed comments from https://code.wireshark.org/review/767/
    
    From Alexis La Goutte
    Fix unused variable (pinfo) and fix crash (wrong variable in while)
    
    Change-Id: I1b134585f4d522d3e808069f606beb4aae0488fa
    Reviewed-on: https://code.wireshark.org/review/1164
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  dedc090   Fix -Wunreachable-code found by Clang
    adds  6a80524   Cleanup SPDY dissector.


Summary of changes:
 epan/dissectors/packet-spdy.c |   82 +++++++++++++++++++++++++++--------------
 1 file changed, 55 insertions(+), 27 deletions(-)