Wireshark-commits: [Wireshark-commits] master dfb92df: Fix crash when switching profiles
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 29 Apr 2014 17:06:04 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dfb92dfd674474b89fa6a2d833b01443b1183032
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

dfb92df by Peter Wu (peter@xxxxxxxxxxxxx):

    Fix crash when switching profiles
    
    rescan_packets() starts a new dissection session by free'ing the
    previous state and creating a new one. A reference to the old session
    was not updated though.
    
    This is the only place where epan is overwritten. After init, col_init
    will at some point initialize cf->cinfo.epan with a cf->epan.
    
    Bug: 9463
    Change-Id: I8cf4e0823328f44a0dccfeeec1594f9929829d2d
    Reviewed-on: https://code.wireshark.org/review/1430
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  b60ccf6   Fix an extraneous parentheses warning.
    adds  dfb92df   Fix crash when switching profiles


Summary of changes:
 file.c |    1 +
 1 file changed, 1 insertion(+)