Wireshark-commits: [Wireshark-commits] master 8dc7d16: prefs: prevent double-free on changing prefs
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 29 Apr 2014 04:17:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8dc7d164dcdbb76b0e50d2c853250f5834b43e59
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8dc7d16 by Peter Wu (peter@xxxxxxxxxxxxx):

    prefs: prevent double-free on changing prefs
    
    Prevent double-free when changing profiles. After switching from the
    default profile to a profile without a preferences file,
    saved_at_version will be freed, but a new version will not be inserted
    (because the prefs file is empty). On a subsequent switch to another
    profile, the saved_at_version field is freed again leading to a crash.
    
    Bug: 9463
    Change-Id: Ia9e0936e32603b4676a37dc428bda40c264a6eaa
    Reviewed-on: https://code.wireshark.org/review/1425
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e8cb623   prefs: spelling fix, simplify code
    adds  8dc7d16   prefs: prevent double-free on changing prefs


Summary of changes:
 epan/prefs.c |    2 ++
 1 file changed, 2 insertions(+)