Wireshark-commits: [Wireshark-commits] master b086b78: gtk: fix glib assert for dialogs without can
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 29 Apr 2014 04:11:59 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b086b783c2106bb24ebce425f97dd86036ccbb13
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b086b78 by Peter Wu (peter@xxxxxxxxxxxxx):

    gtk: fix glib assert for dialogs without cancel
    
    Dialogs with only "Save" and "Don't save" buttons do not have a default
    cancel action. Check for the existence of an OK button before
    registering one.
    
    This fixes three warnings when trying to trying to overwrite preferences
    with unknown keys.
    
    Change-Id: Ie583c40d3db8405d94b8d77710a7fb6556eac89d
    Reviewed-on: https://code.wireshark.org/review/1423
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  65700bd   Make a dissector table out of IPv6 Next header.
    adds  b086b78   gtk: fix glib assert for dialogs without cancel


Summary of changes:
 ui/gtk/simple_dialog.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)