Wireshark-commits: [Wireshark-commits] master 72fc075: Fix potential invalid-reads in catapult file
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 28 Apr 2014 21:02:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=72fc075e9a6b3ba79e49668e74a8dd187fc04f8a
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

72fc075 by Evan Huus (eapache@xxxxxxxxx):

    Fix potential invalid-reads in catapult files
    
    As caught by CppCheck, the conditions checking that n is in bounds should
    occur *before* the conditions using n as an index so that if n is out of bounds
    we don't try and use it anyways.
    
    Change-Id: I107c983153aa12203f8c88b14e1addd3807d6b6e
    Reviewed-on: https://code.wireshark.org/review/1415
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  3765e99   With the use of tvb_reported_length_remaining(), there is no need to calculate consumedLen anymore
    adds  72fc075   Fix potential invalid-reads in catapult files


Summary of changes:
 wiretap/catapult_dct2000.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)