Wireshark · Wireshark-commits: [Wireshark-commits] master 3b6789e: packet-mqtt.c: Minor cleanup

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3b6789ecbefd47cd7c5200edab64ecc94dd581c0
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

3b6789e by Bill Meier (wmeier@xxxxxxxxxxx):

    packet-mqtt.c: Minor cleanup
    
    - Create/use an extended value string;
    - Use ...add_text() instead of ..._add_string() for a packet details "header" line
       (Removes a filter named "mqtt" (not the 'protocol' filter));
    - Fix what is (IMO) a slightly misleading display of "Connect Flags";
    - Remove two lines of duplicate code;
    - Localize some variables;
    - Remove some unneeded initializers;
    - Set tab-stops, etc in editor mode-lines to 8;
    - 'offset++' ==> 'offset += 1';
    - Do some minor whitespace changes.
    
    Change-Id: Ia891c6893643790dbb26510f060c4fb6dfe1fe3a
    Reviewed-on: https://code.wireshark.org/review/1304
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  fe195c0   Don't throw for offset at end of TVB with len -1.
    adds  3b6789e   packet-mqtt.c: Minor cleanup


Summary of changes:
 epan/dissectors/packet-mqtt.c |  144 ++++++++++++++++++++---------------------
 1 file changed, 71 insertions(+), 73 deletions(-)