Wireshark-commits: [Wireshark-commits] master fccf62e: Bugfix generating a sequence of "native" typ
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 23 Apr 2014 06:24:35 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fccf62ece2bed528d2bc588875808fd77e1f0eaf
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fccf62e by Michael Mann (mmann78@xxxxxxxxxxxx):

    Bugfix generating a sequence of "native" types.  Bug 9532.
    
    Previously a sequence of "native" types (int, float, etc) generated a proto_tree_add_uint (for the loop over the sequence) and a proto_tree_add_XXX (for the "native" type), but only 1 hf variable was created for the "loop" field, so DISSECTOR_ASSERT_NOT_REACHED would be generated if "native" type != uint.  Now a separate hf_ variable is generated for the "loop" and "native" type.
    
    Also update existing IDL dissectors with new generator logic.
    
    Change-Id: Ie4d1edfd67a8e6f02834573f29f07baf79058534
    Reviewed-on: https://code.wireshark.org/review/1274
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8ab1c80   Another cut-and-pasteo - UCS-4/UTF-32 should fetch 4-byte characters.
    adds  fccf62e   Bugfix generating a sequence of "native" types.  Bug 9532.


Summary of changes:
 epan/dissectors/packet-parlay.c |  350 +++++++++++++++++++++++++++++++++++++--
 epan/dissectors/packet-tango.c  |   29 +++-
 tools/wireshark_gen.py          |   69 +++++++-
 3 files changed, 427 insertions(+), 21 deletions(-)