Wireshark-commits: [Wireshark-commits] master 66a4303: Cache the "tcp_tree" with p_add_proto_data.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 22 Apr 2014 13:45:37 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=66a430349f01c66c45830dab0d959c07338fa341
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

66a4303 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Cache the "tcp_tree" with p_add_proto_data. Bug 9518.
    
    This is more reliable than doing "tree math" and corrects the intention of 5470356154bec50b607e071606f49696429a0c7c which made the incorrect assumption that tcp_dissect_pdus will be called with the tree that is passed into a protocol's main dissection function (directly from TCP).
    
    Change-Id: I6ffc2188420ab74784c7bc2c69aa79ff071c90b6
    Reviewed-on: https://code.wireshark.org/review/1214
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  68eae53   Add Length for Mobility Header Link-Layer Address Option (Type 7)
    adds  66a4303   Cache the "tcp_tree" with p_add_proto_data. Bug 9518.


Summary of changes:
 epan/dissectors/packet-tcp.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)