Wireshark-commits: [Wireshark-commits] master 68f9811: Don't distinguish between "GCC" and "Clang"
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 20 Apr 2014 22:47:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=68f9811b1bed1397d2ba06af63488fe16bc5bb5e
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

68f9811 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't distinguish between "GCC" and "Clang" extra -W flags.
    
    We test whether a given compiler supports a given -W flag, so we don't
    need to separate them and check them only for particular compilers.
    
    To make that even clearer, rename the --enable option from
    --enable-extra-gcc-checks to --enable-extra-compiler-checks, and
    document it as just "do additional -W checks", and rename the
    WIRESHARK_EXTRA_GCC_ CMake variables to WIRESHARK_EXTRA_COMPILER_.
    
    Sync up the lists of warning flags in CMake with the lists in autoconf.
    
    Uncomment -Wdocumentation while we're at it.  If it doesn't work *at
    all*, comment it out until it's fixed, or, better yet, fix it; if it
    still produces warnings, we just leave it among the "extra" flags.
    
    Change-Id: I4042affdade612e4025e2881d08f1ca69d759626
    Reviewed-on: https://code.wireshark.org/review/1226
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  62592ee   [Automatic manuf, services and enterprise-numbers update for 2014-04-20]
    adds  68f9811   Don't distinguish between "GCC" and "Clang" extra -W flags.


Summary of changes:
 CMakeLists.txt |   79 +++++++++++++++++++++++++++++++++++++-------------------
 acinclude.m4   |    2 +-
 configure.ac   |   31 ++++++++++------------
 3 files changed, 67 insertions(+), 45 deletions(-)