Wireshark-commits: [Wireshark-commits] master c03f13b: IPV6 Mobility Header Binding Revocation Ackn
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 19 Apr 2014 17:41:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c03f13bda8be7db381eb52a090af5871706dfb20
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c03f13b by Michael Mann (mmann78@xxxxxxxxxxxx):

    IPV6 Mobility Header Binding Revocation Acknowledge Global field is the wrong bit
    
    According to RFC 5846 (https://tools.ietf.org/html/rfc5846#section-5.2), there are 3 bits in the Binding Revocation Acknowledgement Message, which come in the following order:
    1. Proxy Binding (P)
    2. IPv4 HoA Binding Only (V)
    3. Global (G)
    
    Found by Boaz Brickner
    
    From Alexis: MIP6 dissector is based on old draft...
    
    Closed-bug: 10007
    Change-Id: I570381171e1455cc03fa7b40bf682d6ed7bd0a92
    Reviewed-on: https://code.wireshark.org/review/1203
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  9496733   IPv6 Authentication Header not parsed after Mobility Header
    adds  c03f13b   IPV6 Mobility Header Binding Revocation Acknowledge Global field is the wrong bit


Summary of changes:
 epan/dissectors/packet-mip6.c |   40 ++++++++++++++++++++++++----------------
 1 file changed, 24 insertions(+), 16 deletions(-)