Wireshark · Wireshark-commits: [Wireshark-commits] master 0a5572e: Fix Bug 9951: 'git commit hook isn't calling checkAPIs.pl with a

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0a5572ea77aff392c7925b8ce30c15327c8d28cc
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0a5572e by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    Fix Bug 9951: 'git commit hook isn't calling checkAPIs.pl with arguments for the dissectors'
    
    I recently made a change to packet-rtp.c and inappropriately included
    g_error() in it, which the builbots caught during their run of checkAPIs.pl.
    But checkAPIs.pl is supposed to catch such things for us before we submit, by
    being invoked in the git pre-commit hook.
    
    Apparently though, buildbots call checkAPIs.pl with extra arguments for
    different cases... and for packet dissectors it calls it with a '-g abort'
    argument, which is how it caught the g_error.
    
    So the "bug" is that the pre-commit hook should invoke checAPIs.pl with that
    argument too, for epan/dissectors/packet-*.c files.
    
    Change-Id: Ie8f9dcc55f2248918208dea85a04f67e6bf9829a
    Reviewed-on: https://code.wireshark.org/review/953
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  f532fb9   MBIM: fix dissection of ENVELOPE Sim Toolkit messages
    adds  0a5572e   Fix Bug 9951: 'git commit hook isn't calling checkAPIs.pl with arguments for the dissectors'


Summary of changes:
 tools/checkAPIs.pl |   14 ++++++++++++++
 tools/pre-commit   |    2 +-
 2 files changed, 15 insertions(+), 1 deletion(-)