Wireshark-commits: [Wireshark-commits] master cb16dff: Get rid of more tvb_get_nstringz* calls.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 12 Apr 2014 22:27:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cb16dff992c3844936bf5829f19e5a5247458503
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cb16dff by Guy Harris (guy@xxxxxxxxxxxx):

    Get rid of more tvb_get_nstringz* calls.
    
    Add an FT_STRINGZPAD type, for null-padded strings (typically
    fixed-length fields, where the string can be up to the length of the
    field, and is null-padded if it's shorter than that), and use it.  Use
    IS_FT_STRING() in more cases, so that less code needs to know what types
    are string types.
    
    Add a tvb_get_stringzpad() routine, which gets null-padded strings.
    Currently, it does the same thing that tvb_get_string_enc() does, but
    that might change if we don't store string values as null-terminated
    strings.
    
    Change-Id: I46f56e130de8f419a19b56ded914e24cc7518a66
    Reviewed-on: https://code.wireshark.org/review/1082
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  ef8a0a2   Update E.212 list to Operational Bulletin No. 1047 (1.III.2014)
    adds  cb16dff   Get rid of more tvb_get_nstringz* calls.


Summary of changes:
 epan/dfilter/dfunctions.c           |   53 ++++++++++------------------
 epan/dfilter/semcheck.c             |    4 +++
 epan/dissectors/packet-fw1.c        |    3 +-
 epan/dissectors/packet-hartip.c     |   52 +++++++++------------------
 epan/dissectors/packet-ospf.c       |    4 +--
 epan/dissectors/packet-quake3.c     |   18 +++++++---
 epan/dissectors/packet-quakeworld.c |   20 +++++------
 epan/dissectors/packet-rsync.c      |    8 +++--
 epan/dissectors/packet-smb-browse.c |   28 ++++++---------
 epan/dissectors/packet-tacacs.c     |   11 +++---
 epan/dissectors/packet-who.c        |   17 ++++-----
 epan/ftypes/ftype-string.c          |   43 +++++++++++++++++++++++
 epan/ftypes/ftypes.h                |    3 +-
 epan/packet.c                       |    3 ++
 epan/proto.c                        |   66 ++++++++++++++++++++++-------------
 epan/proto.h                        |   13 +++----
 epan/tvbuff.c                       |   18 ++++++++++
 epan/tvbuff.h                       |   23 ++++++++++++
 rawshark.c                          |    4 ++-
 tfshark.c                           |    4 +++
 tshark.c                            |    4 +++
 ui/decode_as_utils.c                |    6 +++-
 ui/gtk/decode_as_dlg.c              |    2 ++
 ui/gtk/dissector_tables_dlg.c       |    4 +++
 ui/gtk/main.c                       |    2 +-
 ui/gtk/packet_win.c                 |    2 +-
 ui/qt/decode_as_dialog.cpp          |    8 +++--
 27 files changed, 261 insertions(+), 162 deletions(-)