Wireshark-commits: [Wireshark-commits] master 1c162ff: Clean up the dissection of ServiceContexts.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 9 Apr 2014 09:45:15 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1c162ffc7e59e9c669d8b7ef9232c9bbf719ae9a
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1c162ff by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up the dissection of ServiceContexts.
    
    Make the top-level item for a ServiceContext an item for the
    ServiceContext as a while, and put the VSCID under it like other items,
    rather than making the VSCID the top-level item.
    
    Don't dissect the VSCID using the value_string field for the Object
    Management Group's SCIDs; use that value_string field for the SCID if
    the VSCID is 0 (meaning "Object Management Group"), and have no
    value_string field for the VSCID otherwise (the interpretation of the
    SCID depends on the value of the VSCID).
    
    Dissect the encapsulation information even for unknown ServiceContexts.
    
    If the ServiceContext's length is bigger than what it's supposed to be,
    throw an exception if it's also bigger than the data available in the
    packet; this squelches a run-time warning in that case.
    
    Change-Id: I11cc62c2e32f4623dba2a551119b3146a7037e6d
    Reviewed-on: https://code.wireshark.org/review/1038
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  9c14703   remove usb_trans_info parameter trans_info is part of the conversation info
    adds  1c162ff   Clean up the dissection of ServiceContexts.


Summary of changes:
 epan/dissectors/packet-giop.c |  204 ++++++++++++++++++++++++-----------------
 1 file changed, 119 insertions(+), 85 deletions(-)