Wireshark-commits: [Wireshark-commits] master beb4876: Don't assume the data pointed to by an addre
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=beb4876cb4dda2b9964c223041386e5e6e33a31e
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
beb4876 by Guy Harris (guy@xxxxxxxxxxxx):
Don't assume the data pointed to by an address structure is aligned.
And don't assume you can dereference the pointer nonetheless; that
doesn't work on SPARC, for example - you get an unaligned-access trap.
Instead, use pntoh32() to fetch IPv4 address values from the address
structures.
While we're at it, just use guint32 for those addresses; we don't need
in_addr_t.
Change-Id: I84e6c653fe33b1bc6e67d9097ce423b82f1eb0c8
Reviewed-on: https://code.wireshark.org/review/1024
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from 0f0c079 Add commit-msg hook to tools to spare searching for it
adds beb4876 Don't assume the data pointed to by an address structure is aligned.
Summary of changes:
epan/dissectors/packet-lbmr.c | 15 +++++----------
epan/dissectors/packet-lbtrm.c | 19 +++++++------------
2 files changed, 12 insertions(+), 22 deletions(-)