Wireshark-commits: [Wireshark-commits] master 872dd70: Don't pretend that sizeof(guintN) will give
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 8 Apr 2014 01:52:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=872dd7031b2d4208669ca9f6e78d1e774c3c4902
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

872dd70 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't pretend that sizeof(guintN) will give us more robust values.
    
    What matter in these cases is the number of bytes on the wire; either
    sizeof(guint8) = 1, sizeof(guint16) = 2, and sizeof(guint32) = 4, in
    which case just using 1, 2, and 4 avoids "64-bit to 32-bit conversion"
    warnings on LP64 and LLP64 environments, or they're not equal, in which
    case using 1, 2, and 4 rather than the sizeof()s is correct.
    
    Change-Id: I4f15c5fae51958c1aff17ff819a9878fa6bd1f54
    Reviewed-on: https://code.wireshark.org/review/999
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  75dcbc4   Make sure packet-lbttcp.h ends up in the release tarball.
    adds  872dd70   Don't pretend that sizeof(guintN) will give us more robust values.


Summary of changes:
 epan/dissectors/packet-lbmpdm.c |   30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)