Wireshark-commits: [Wireshark-commits] master 26f46d4: Handle string types with somewhat appropriat
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 7 Apr 2014 22:46:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=26f46d40e9cc0feab71280fbff57d70beac20acc
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

26f46d4 by Guy Harris (guy@xxxxxxxxxxxx):

    Handle string types with somewhat appropriate encodings.
    
    For various string types defined in X.680, use the appropriate encoding,
    or ENC_ASCII|ENC_NA in some cases where we don't have an appropriate
    encoding yet.
    
    This most significantly fixes the handling of BMPString and
    UniversalString, which are supersets of ASCII (Unicode Basic
    Multilingual Plane and Unicode, respectively), but don't encode ASCII
    characters as single octets.  It also fixes UTF8String to, well,
    properly recognize UTF-8.
    
    This also lets us get rid of the special handling of SyntaxBMPString in
    X.509sat (and, in fact, *requires* us to get rid of it, as, otherwise,
    the string value appears twice).
    
    Change-Id: I325c4e71a6110278eb23b86e0d986e6439cfc328
    Reviewed-on: https://code.wireshark.org/review/994
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  a5cb72f   Add a Qt I/O Graph dialog.
    adds  26f46d4   Handle string types with somewhat appropriate encodings.


Summary of changes:
 asn1/x509sat/x509sat.cnf         |   14 -------
 epan/dissectors/packet-ber.c     |   82 +++++++++++++++++++++++++++++++++++++-
 epan/dissectors/packet-x509sat.c |   16 +-------
 3 files changed, 83 insertions(+), 29 deletions(-)