Wireshark-commits: [Wireshark-commits] master 70ad7d8: Move the status dissecting code to the AFP d
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 6 Apr 2014 19:13:50 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=70ad7d8fd3a40bd9a5e30860c6bbbd0ab801ebe2
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

70ad7d8 by Guy Harris (guy@xxxxxxxxxxxx):

    Move the status dissecting code to the AFP dissector.
    
    The ASP and DSI dissectors had almost-identical dissection of the ASP
    and DSI "status" responses. What's being dissected is defined by the AFP
    specification (and might be different for protocols *other* than AFP
    running atop AFP or DSI), so move that dissection to the AFP dissector.
    
    Note that, at least for AFP-over-DSI, the spec isn't being followed in
    at least one capture.
    
    Change-Id: Idb1013483f3a3bdf2b7eb0618e48fc178a338642
    Reviewed-on: https://code.wireshark.org/review/987
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  5a67479   Fix indent (use 2 spaces) and add modelinse info for frame_data.h
    adds  70ad7d8   Move the status dissecting code to the AFP dissector.


Summary of changes:
 epan/dissectors/packet-afp.c   |  506 +++++++++++++++++++++++++++++++++++++++-
 epan/dissectors/packet-atalk.c |  403 +-------------------------------
 epan/dissectors/packet-dsi.c   |  423 +--------------------------------
 3 files changed, 521 insertions(+), 811 deletions(-)