Wireshark · Wireshark-commits: [Wireshark-commits] master 04c05a2: Fix Bug 9920 Buildbot crash due to SDP/RTP mismatch

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=04c05a21e34cec326f1aff2f5f8a6e74e1ced984
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

04c05a2 by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    Fix Bug 9920 Buildbot crash due to SDP/RTP mismatch
    
    For details see comments in Bug 9920.
    
    The executive summary:
    Bug 9920 is a crash caused by a couple of issues:
    
    1) The memory ownership model for the rtp_dyn_payload hashtable is split: SDP
    creates the rtp_dyn_payload hashtable, but RTP can free it. Since there isn't
    *one* pointer to the hashtable, RTP freeing it means SDP has a dangling
    pointer.
    
    2) Either the SDP dissector shouldn't be creating two separate, unique
    hashtables for multiple media channels of the same addr:port, or RTP shouldn't
    be free'ing the previous one.
    
    Change-Id: I436e67de6882f84aa82dcbdfe60bf313fe4fd99c
    Reviewed-on: https://code.wireshark.org/review/918
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  df80f31   Fix a typo
    adds  04c05a2   Fix Bug 9920 Buildbot crash due to SDP/RTP mismatch


Summary of changes:
 asn1/h245/packet-h245-template.c   |   12 +-
 epan/dissectors/packet-ansi_a.c    |   26 +--
 epan/dissectors/packet-applemidi.c |   13 +-
 epan/dissectors/packet-h245.c      |   22 +--
 epan/dissectors/packet-rtp.c       |  322 ++++++++++++++++++++++++++++++------
 epan/dissectors/packet-rtp.h       |   82 +++++++--
 epan/dissectors/packet-sdp.c       |  107 ++++--------
 ui/gtk/voip_calls.c                |    7 +-
 8 files changed, 395 insertions(+), 196 deletions(-)