Wireshark-commits: [Wireshark-commits] master 84bc050: In the string handling routines don't call t
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 3 Apr 2014 04:08:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=84bc050a89c2200f2392630e4281fddfd96b2452
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

84bc050 by AndersBroman (anders.broman@xxxxxxxxxxxx):

    In the string handling routines don't call tvb_get_...() inside the loops insted get the ptr and read
    directly avoiding the overhead of calling fast_ensure_contiguous()
    repeatibly.
    
    Change-Id: Ib5eee87ef9d49cb4e46b3b9c3d3db0134d3c4a32
    Reviewed-on: https://code.wireshark.org/review/889
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e982992   For single-precision calculations, use single-precision constants.
    adds  84bc050   In the string handling routines don't call tvb_get_...() inside the loops insted get the ptr and read directly avoiding the overhead of calling fast_ensure_contiguous() repeatibly.


Summary of changes:
 epan/tvbuff.c |   98 ++++++++++++++++++++++++++++++++++++++++-----------------
 1 file changed, 70 insertions(+), 28 deletions(-)