Wireshark-commits: [Wireshark-commits] master 29519c4: Remove extra parenthesis in EQ_SEQ.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 2 Apr 2014 19:53:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=29519c447665068e3f40cdb9699e6ec39561a17e
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

29519c4 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Remove extra parenthesis in EQ_SEQ.
    
    Fixes the following clang warning:
    
    epan/follow.c:397:20: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
      if ( ((sequence) == (seq[src_index])) ) {
            ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
    epan/follow.c:397:20: note: remove extraneous parentheses around the comparison to silence this warning
      if ( ((sequence) == (seq[src_index])) ) {
           ~           ^                  ~
    epan/follow.c:397:20: note: use '=' to turn this equality comparison into an assignment
      if ( ((sequence) == (seq[src_index])) ) {
                       ^~
                       =
    
    Change-Id: Ic257bbc598e17f854b671056887ca1a13dcea850
    Reviewed-on: https://code.wireshark.org/review/928
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  b8b68f7   dissect the chrm chunk
    adds  29519c4   Remove extra parenthesis in EQ_SEQ.


Summary of changes:
 epan/dissectors/packet-tcp.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)