Wireshark-commits: [Wireshark-commits] master b238cd1: Scrap wmem splay trees for now.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 2 Apr 2014 17:14:18 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b238cd15413ec3863b753dae1e71b02c210aeb1b
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b238cd1 by Evan Huus (eapache@xxxxxxxxx):

    Scrap wmem splay trees for now.
    
    There is confusion about API usage, and problems on my part concerning whether
    keys should be compared signed or unsigned, and how to do that efficiently.
    Unsigned keys in particular were behaving oddly.
    
    Change-Id: I075693bbd04c15f79f24f9a24006003a914cc572
    Reviewed-on: https://code.wireshark.org/review/924
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  9410882   Add a cople of missing pcap.extension IE:s
    adds  b238cd1   Scrap wmem splay trees for now.


Summary of changes:
 epan/CMakeLists.txt       |    1 -
 epan/wmem/Makefile.common |    2 -
 epan/wmem/wmem.h          |    1 -
 epan/wmem/wmem_splay.c    |  368 ---------------------------------------------
 epan/wmem/wmem_splay.h    |  161 --------------------
 epan/wmem/wmem_test.c     |  186 -----------------------
 6 files changed, 719 deletions(-)
 delete mode 100644 epan/wmem/wmem_splay.c
 delete mode 100644 epan/wmem/wmem_splay.h