Wireshark-commits: [Wireshark-commits] master 5838881: Have Infiniband dissector show payload. Bug
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 2 Apr 2014 14:05:46 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5838881f2e2dc985fe3b890bb855d765bff9dbd8
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5838881 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Have Infiniband dissector show payload. Bug 9929.
    
    The trees in the infiniband dissectors were incorrectly setup causing the data dissector to always have a NULL tree (so it wouldn't appear in packet view).
    
    Also cleaned up some other unnecessary global variables.
    
    Change-Id: I778073bdca864dfc5087cdcfc7ef0018f9bd704c
    Reviewed-on: https://code.wireshark.org/review/915
    Tested-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  8570f17   Fix packet-bootp.c:5368:18: error: 'ti' may be used uninitialized in this function
    adds  5838881   Have Infiniband dissector show payload. Bug 9929.


Summary of changes:
 epan/dissectors/packet-infiniband.c |  147 +++++++++++------------------------
 1 file changed, 47 insertions(+), 100 deletions(-)