Wireshark-commits: [Wireshark-commits] master 97cddf5: Fix proto.c to pass checkAPIs script
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 1 Apr 2014 06:04:00 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=97cddf538c6438b1b995e742c3152b50be1d18d3
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

97cddf5 by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    Fix proto.c to pass checkAPIs script
    
    Since proto.c was using strcat(), changes to the file won't pass checkAPIs.
    So this commit replaces it with the appropriate function, and also replaces
    the deprecated tvb_length_remaining and tvb_ensure_length_remaining function
    calls with the new versions, since checkAPIs was warning about that too.
    This commit does not change the ep_* memorry calls to the new wmem-based
    ones though, as that's a bigger deal than this trivial commit I think.
    
    Change-Id: I51e6d5b3a6e03233f2695c890ff4c10d02fdb0c0
    Reviewed-on: https://code.wireshark.org/review/905
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  dc4c26c   Update encap_table_base.
    adds  97cddf5   Fix proto.c to pass checkAPIs script


Summary of changes:
 epan/proto.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)