Wireshark-commits: [Wireshark-commits] master 8ffdf42: Add a pcorey48tohll() macro, and use #define
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 29 Mar 2014 20:11:49 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8ffdf4249aabae6ac653ecd29b1f8970d156278f
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8ffdf42 by Guy Harris (guy@xxxxxxxxxxxx):

    Add a pcorey48tohll() macro, and use #defines for some offsets.
    
    The "48 bits, in a weird byte order" is a variant of 64-bit
    "Corey-endian", with the upper 16 bits of the result - which are in the
    *middle* of the bytes of the number - ignored.  Define a pcorey48tohll()
    macro and use that, rather than the loop.
    
    There are a bunch of #defines for offsets in the headers; use them
    rather than magic constants.
    
    Change-Id: Idfdc8a741278d71a5db47c067914c97615c3e02d
    Reviewed-on: https://code.wireshark.org/review/864
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  521bab1   Use sized strbufs when extracting tvb strings
    adds  8ffdf42   Add a pcorey48tohll() macro, and use #defines for some offsets.


Summary of changes:
 wiretap/vwr.c |   51 +++++++++++++++++++++++++--------------------------
 1 file changed, 25 insertions(+), 26 deletions(-)